CI: Harden GHA configuration #243
Open
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the possibility of a tag being changed under us.
May include: - Avoids risky string interpolation. - Prevents checkout premissions from leaking
Reduces risk of arbitrary code is run by attacker.
dopplershift
requested changes
Jul 18, 2025
Co-authored-by: Ryan May <[email protected]>
|
I don't think either of those failures is due to this change, but I'm not 100% sure on that. |
We need them later.
Cadair
approved these changes
Jul 22, 2025
.github/dependabot.yml
Outdated
| - package-ecosystem: "github-actions" | ||
| directory: "/" # Location of your workflow files | ||
| schedule: | ||
| interval: "weekly" # Options: daily, weekly, monthly |
There was a problem hiding this comment.
Can we monthly? The repo isn't super active and I have so many bot PRs to review these days. 😅
There was a problem hiding this comment.
I'll change it to monthly, although if your actions don't change much faster than that it does not super matter.
I'm not super worried about what the cadence is, but I would like there to be some process to make sure that the actions are kept up to date.
There was a problem hiding this comment.
For sure, definitely want the update.
Co-authored-by: Stuart Mumford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply recommended hardening steps including: